Ensure time units used in AMQP(S) URIs are correct

[michaelklishin]

trafficstars

From https://github.com/rabbitmq/rabbitmq-server/issues/1015:

When creating a federation upstream, in the uri if connection_timeout amqp param is added it needs to be in milliseconds not seconds according to the documentation.  This was found in 3.4.3.

Example
amqp://user:password@SERVER?heartbeat=10&connection_timeout=10

should be

amqp://user:password@SERVER?heartbeat=10&connection_timeout=10000

[michaelklishin]

There are three problems here:

• Heartbeat is required to be in seconds per spec
• Connection timeout doesn't have this restriction
• Backwards compatibility

therefore we might end up only updating the docs. But Erlang client/Shovel/Federation changes would also be considered.

[TadMelton]

THANKS!