rabbitmq-stream-dotnet-client icon indicating copy to clipboard operation
rabbitmq-stream-dotnet-client copied to clipboard

Add file for strong naming assembly

Open lukebakken opened this issue 2 years ago • 6 comments

If you use sn -T on the version 1.3.0 RabbitMQ dll, you get this:

lib\net6.0> sn -T .\RabbitMQ.Stream.Client.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

.\RabbitMQ.Stream.Client.dll does not represent a strongly named assembly

lukebakken avatar May 03 '23 20:05 lukebakken

This probably will have to be a 2.0.0 thing.

lukebakken avatar May 03 '23 20:05 lukebakken

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (2f1be23) 93.01% compared to head (077f364) 93.05%.

:exclamation: Current head 077f364 differs from pull request most recent head 20f34cd. Consider uploading reports for the commit 20f34cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   93.01%   93.05%   +0.03%     
==========================================
  Files         107      104       -3     
  Lines        9204     9139      -65     
  Branches      724      722       -2     
==========================================
- Hits         8561     8504      -57     
+ Misses        496      489       -7     
+ Partials      147      146       -1     

see 5 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '23 20:05 codecov[bot]

Building from this PR and running the same command yields:

sn -T RabbitMQ.Stream.Client/bin/Debug/net6.0/RabbitMQ.Stream.Client.dll
Mono StrongName - version 6.12.0.0
StrongName utility for signing assemblies
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Public Key Token:

Does it mean it has strong assembly? 🙈 This was on Mac OS.

Zerpet avatar May 04 '23 08:05 Zerpet

You know I could actually have tested that 🤦

lukebakken avatar May 09 '23 14:05 lukebakken

Hmm the tests run fine in my Ubuntu / WSL environment, I don't see this error:

System.MethodAccessException : Attempt by method 'Tests.ConsumerSystemTests+<ConsumerValidationAmqpAttributes>d__8.MoveNext()' to access method 'RabbitMQ.Stream.Client.Message.set_Annotations(RabbitMQ.Stream.Client.AMQP.Annotations)' failed.

I'll figure it out. It has to do with the InternalsVisisbleTo attribute that allows the tests project to use internal types.

lukebakken avatar May 09 '23 16:05 lukebakken

I get a public key token now:

sn -T RabbitMQ.Stream.Client/bin/Debug/net6.0/RabbitMQ.Stream.Client.dll
Mono StrongName - version 6.12.0.0
StrongName utility for signing assemblies
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Public Key Token: f7b36e2fabae37d5

Should be good to go when CI passes 👍

Zerpet avatar May 10 '23 15:05 Zerpet