rabbitmq-stream-dotnet-client icon indicating copy to clipboard operation
rabbitmq-stream-dotnet-client copied to clipboard

Write to the outgoing pipeline directly

Open lukebakken opened this issue 2 years ago • 3 comments

I still have benchmarking to do, but this method should be faster.

Learning a bit after reading about System.IO.Pipelines - link

lukebakken avatar Mar 03 '23 00:03 lukebakken

That's great @lukebakken !

Gsantomaggio avatar Mar 03 '23 14:03 Gsantomaggio

Codecov Report

Patch coverage: 95.69% and project coverage change: +0.30 :tada:

Comparison is base (e42d8fe) 92.80% compared to head (1175caa) 93.11%.

:exclamation: Current head 1175caa differs from pull request most recent head 9bbd2cd. Consider uploading reports for the commit 9bbd2cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   92.80%   93.11%   +0.30%     
==========================================
  Files         102      102              
  Lines        8869     8810      -59     
  Branches      704      676      -28     
==========================================
- Hits         8231     8203      -28     
+ Misses        492      468      -24     
+ Partials      146      139       -7     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Client.cs 92.84% <ø> (+0.92%) :arrow_up:
RabbitMQ.Stream.Client/CloseResponse.cs 82.35% <ø> (ø)
...bitMQ.Stream.Client/ConsumerUpdateQueryResponse.cs 85.00% <ø> (ø)
RabbitMQ.Stream.Client/CreditResponse.cs 70.00% <ø> (ø)
RabbitMQ.Stream.Client/DeclarePublisherResponse.cs 82.35% <ø> (ø)
RabbitMQ.Stream.Client/DeletePublisherResponse.cs 82.35% <ø> (ø)
RabbitMQ.Stream.Client/Deliver.cs 95.45% <ø> (-0.50%) :arrow_down:
RabbitMQ.Stream.Client/ICommand.cs 50.00% <ø> (ø)
RabbitMQ.Stream.Client/OpenResponse.cs 90.00% <ø> (ø)
RabbitMQ.Stream.Client/PartitionsQueryResponse.cs 91.30% <ø> (ø)
... and 34 more

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 03 '23 15:03 codecov[bot]

Have you tried the perf test with this PR to see if there is any improvement?

Gsantomaggio avatar Aug 01 '23 15:08 Gsantomaggio