rabbitmq-stream-dotnet-client icon indicating copy to clipboard operation
rabbitmq-stream-dotnet-client copied to clipboard

Fix style in select classes to be more dotnet-like

Open ricardSiliuk opened this issue 3 years ago • 1 comments

Misc fixes related to style. Basically prefixing private variables in select classes with _.

ricardSiliuk avatar Jul 31 '22 11:07 ricardSiliuk

Codecov Report

Base: 92.70% // Head: 92.88% // Increases project coverage by +0.17% :tada:

Coverage data is based on head (966d235) compared to base (b91ab49). Patch coverage: 87.93% of modified lines in pull request are covered.

:exclamation: Current head 966d235 differs from pull request most recent head aba4ca6. Consider uploading reports for the commit aba4ca6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   92.70%   92.88%   +0.17%     
==========================================
  Files          94       94              
  Lines        7839     7840       +1     
  Branches      592      592              
==========================================
+ Hits         7267     7282      +15     
+ Misses        457      446      -11     
+ Partials      115      112       -3     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/RawProducer.cs 82.79% <79.59%> (+1.86%) :arrow_up:
RabbitMQ.Stream.Client/RawConsumer.cs 89.24% <90.62%> (+2.53%) :arrow_up:
RabbitMQ.Stream.Client/StreamSystem.cs 86.58% <96.96%> (-0.06%) :arrow_down:
...bitMQ.Stream.Client/Reliable/IReconnectStrategy.cs 80.95% <100.00%> (+2.00%) :arrow_up:
RabbitMQ.Stream.Client/Client.cs 92.04% <0.00%> (+0.72%) :arrow_up:
RabbitMQ.Stream.Client/Reliable/ReliableBase.cs 96.29% <0.00%> (+1.23%) :arrow_up:
RabbitMQ.Stream.Client/Connection.cs 89.16% <0.00%> (+1.66%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 31 '22 11:07 codecov[bot]

I'll continue work on this PR since I should be able to push to your fork @ricardSiliuk. I need to reconcile the .editorconfig settings we use in this project with those in the .NET AMQP client.

lukebakken avatar Nov 07 '22 17:11 lukebakken