rabbitmq-server icon indicating copy to clipboard operation
rabbitmq-server copied to clipboard

Use a more unique exchange names in federation exchange suite

Open kjnilsson opened this issue 3 years ago • 3 comments

This is to avoid a case where multiple policies are matches for a given exchange and the federation exchage suite causing indeterminacy in the policy being applied to certain exchanges. This caused failures due to internal changes in ETS set ordering between OTP 24 and 25.

kjnilsson avatar Jun 13 '22 12:06 kjnilsson

This pull request modifies the bazel build only. If it is a deps update or app_env change, remember to sync any changes to the makefiles.

mergify[bot] avatar Jun 26 '22 17:06 mergify[bot]

@michaelklishin was there any reason this wasn't merged previously?

HoloRin avatar Jul 20 '22 10:07 HoloRin

It does not fully help IIRC. I was going to finish it. Still hope to do :)


From: Rin Kuryloski @.> Sent: Wednesday, July 20, 2022 2:24:26 PM To: rabbitmq/rabbitmq-server @.> Cc: Michael Klishin @.>; Mention @.> Subject: Re: [rabbitmq/rabbitmq-server] Use a more unique exchange names in federation exchange suite (PR #5028)

⚠ External Email

@michaelklishinhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmichaelklishin&data=05%7C01%7Cklishinm%40vmware.com%7Cbc27248a2dad4690af0e08da6a3a0606%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637939094688932278%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HR1GKuCTBKHJjihxjgytaWFoTXjGvLzOcH9y4BF5sLk%3D&reserved=0 was there any reason this wasn't merged previously?

— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frabbitmq%2Frabbitmq-server%2Fpull%2F5028%23issuecomment-1190100722&data=05%7C01%7Cklishinm%40vmware.com%7Cbc27248a2dad4690af0e08da6a3a0606%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637939094689088492%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fcAOfnwNTesMa61Q0WScxpcRes6m2tpUwevwDC1lfVQ%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAAIQSOZNJ6HYIUMPTXZ73VU7HVVANCNFSM5YUDA2VA&data=05%7C01%7Cklishinm%40vmware.com%7Cbc27248a2dad4690af0e08da6a3a0606%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637939094689088492%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2ngdUSvYAL%2FTd1V6IZDDSIQZqm8fwf6jkOfFucbXdOs%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>


⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.

michaelklishin avatar Jul 20 '22 11:07 michaelklishin

@michaelklishin can we close this?

kjnilsson avatar Sep 27 '22 11:09 kjnilsson

Superseded by a more drastic exchange federation test suite refactoring

michaelklishin avatar Oct 06 '22 05:10 michaelklishin