rabbitmq-server icon indicating copy to clipboard operation
rabbitmq-server copied to clipboard

Add quorum_queue_prop_SUITE

Open lhoguin opened this issue 3 years ago • 6 comments

This adds a property suite for QQs that is ported over from the property suite I wrote for CQs.

This PR includes or contributed to 3 fixes: a clause was removed in rabbit_fifo_client that caused some commands to be dropped after a ra leader restarted and became leader again (merged in 3.10); and two new case clauses to deal with the ra process being restarted or killed (in this PR).

lhoguin avatar Feb 22 '22 13:02 lhoguin

I have updated the patch Ra needs to run this test suite without getting stuck.

lhoguin avatar Mar 03 '22 11:03 lhoguin

This pull request modifies the bazel build only. Should the makefiles be updated as well @lhoguin?

mergify[bot] avatar Mar 11 '22 10:03 mergify[bot]

The test suite seems good but in order to merge a small PR would first need to be sent to ra to allow for ra systems to crash more often than currently allowed (an application env value to set the intensity would do, like the patch in the first post), and then probably a good idea to squash the commits. Then the merge order would have to be merge the ra PR, increase ra version in main, update the test suite and merge. I will do the ra PR now.

lhoguin avatar Sep 28 '22 15:09 lhoguin

The tests are expected to fail until https://github.com/rabbitmq/ra/pull/312 is merged.

lhoguin avatar Sep 29 '22 13:09 lhoguin

This is ready for review/merge.

This should be compatible with 3.10+ if you want to backport.

lhoguin avatar Apr 07 '23 09:04 lhoguin

This pull request modifies the bazel build only. Should the makefiles be updated as well @lhoguin?

No! Erlang.mk picks up new test suites automatically.

lhoguin avatar Apr 07 '23 09:04 lhoguin