rabbitmq-server icon indicating copy to clipboard operation
rabbitmq-server copied to clipboard

Published 20 hours ago • verified publisher icon rabbitmq

4.x: remove availability of CQv1

Open lhoguin opened this issue 1 year ago • 2 comments

Most of the v1 code is still around as it is needed for conversion to v2. It will be removed at a later time when conversion is no longer supported.

A few notes:

  • classic_queue_default_version: currently it remains but is unused. We validate the value and if it selects v1 we abort with an informative error
  • Both x-queue-version and x-queue-mode remain. We can't really remove them. They are ignored
  • Most of the v1 code is still around as it is needed for the automatic conversion

Type of Changes

  • [x] Breaking change (fix or feature that would cause an observable behavior change in existing systems)

lhoguin avatar Mar 04 '24 09:03 lhoguin

The forced push is a rebase.

michaelklishin avatar Mar 04 '24 16:03 michaelklishin

I do not understand why Peer Discovery AWS Integration Test is failing. It is likely related to the changes in this PR as I haven't seen this failure consistently elsewhere. I could use some help in figuring out the cause. The PR is otherwise ready for review. Thank you!

Edit: This might be "normal" and should work on main.

lhoguin avatar Mar 12 '24 12:03 lhoguin