rabbitmq-server icon indicating copy to clipboard operation
rabbitmq-server copied to clipboard

Definitions export from management UI does not include vhost metadata

Open lukebakken opened this issue 1 year ago • 2 comments

https://vmware.slack.com/archives/C0RDGG81Z/p1707224857559109

Reproduction steps:

Create vhost

rabbitmqctl add_vhost test --default-queue-type quorum

Export using CLI

rabbitmqctl export_definitions test-vhost-with-queue-type-from-cli.json

Note that the above file includes vhost metadata:

    "vhosts": [
        {
            "limits": [],
            "metadata": {
                "description": "Default virtual host",
                "tags": []
            },
            "name": "/"
        },
        {
            "limits": [],
            "metadata": {
                "description": "",
                "tags": [],
                "default_queue_type": "quorum"
            },
            "name": "test"
        }
    ],

Export using management UI

Note that the exported file does NOT contain metadata:

    "vhosts": [
        {
            "name": "/"
        },
        {
            "name": "test"
        }
    ],

lukebakken avatar Feb 07 '24 17:02 lukebakken

@lukebakken thank you for digging in and providing the details.

michaelklishin avatar Feb 07 '24 17:02 michaelklishin

cc @pvladMQ

lukebakken avatar Feb 07 '24 17:02 lukebakken

https://github.com/rabbitmq/rabbitmq-server/pull/11538 addresses the essential part of it. Virtual host limits are not considered to be, well, virtual host parameters by the HTTP API and the internally used schema database. They are runtime parameters.

So I think https://github.com/rabbitmq/rabbitmq-server/pull/11538 is an acceptable solution, at least for now.

michaelklishin avatar Jun 23 '24 18:06 michaelklishin