r1viollet
r1viollet
@nsavoire do you mind moving this to draft if we do not plan on merging soon ?
# Artifact Size Benchmark Report aarch64-alpine-linux-musl | Artifact | Baseline | Commit | Change | |----------|-----------|-------------|------------| | /aarch64-alpine-linux-musl/lib/libdatadog_profiling.a|77.38 MB|77.38 MB|0% (0 B) 👌 | | /aarch64-alpine-linux-musl/lib/libdatadog_profiling.so|7.76 MB|7.76 MB|0% (0 B)...
@zBart hs_err files are welcome. They help us identify how we can further protect the usage of AsyncGetCallTrace. Reproducers are even better, though I can see how that is hard...
# Artifact Size Benchmark Report aarch64-alpine-linux-musl | Artifact | Baseline | Commit | Change | |----------|-----------|-------------|------------| | /aarch64-alpine-linux-musl/lib/libdatadog_profiling.a|65.98 MB|68.04 MB|+3.13% (+2.06 MB) ⚠️ | | /aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug|20.28 MB|21.15 MB|+4.27% (+888.62 KB)...
@hoolioh do you need help to push this ? It would be interesting to have this for everyone.
Here is a dockerfile using a recent alpine. ``` ARG BASE_IMAGE="alpine:3.21.2" FROM ${BASE_IMAGE} AS base RUN apk update \ && apk add --no-cache \ build-base \ cargo \ cmake \...
This was also visible on older alpine versions, using `0.3.74`. The example uses 0.3.75, as can be seen in the example cargo files: ``` backtrace = { git = "https://github.com/rust-lang/backtrace-rs",...
I wonder if the difference could be induced by the fact that libunwind is pulled from [ubuntu](https://github.com/rust-lang/backtrace-rs/blob/master/ci/docker/x86_64-unknown-linux-musl/Dockerfile). Whereas I recompile libunwind from alpine.
So I had to split the examples as I had mixed C unwinding with libunwind along with backtrace-rs unwinding. New examples are [here](https://github.com/DataDog/libdatadog/commit/474b67b7727b47a1a8a704ee55c4754fbc2bc150). With the new setup, we have separate...
So I think I confused you with my setup. - unwind_c: I do things manually to compare the unwinding, I link manually (and I do not need the backtrace-rs dependency)....