cljs-http icon indicating copy to clipboard operation
cljs-http copied to clipboard

Function redefinition warnings with Clojure/Script 1.11

Open esp1 opened this issue 3 years ago • 1 comments

When using Clojure/Script 1.11, you will get function redefinition warnings because cljs-http depends on noencore, which defines parse-long and parse-double functions which are now included in clojure.core.

------ WARNING #1 - :redef -----------------------------------------------------
 Resource: no/en/core.cljc:131:1
--------------------------------------------------------------------------------
 128 |   [s]
 129 |   (parse-number s #(#?(:clj Integer/parseInt :cljs js/parseInt) %1)))
 130 | 
 131 | (defn parse-long
-------^------------------------------------------------------------------------
 parse-long already refers to: cljs.core/parse-long being replaced by: no.en.core/parse-long
--------------------------------------------------------------------------------
 132 |   "Parse `s` as a long number."
 133 |   [s]
 134 |   (parse-number s #(#?(:clj Long/parseLong :cljs js/parseInt) %1)))
 135 | 
--------------------------------------------------------------------------------

------ WARNING #2 - :redef -----------------------------------------------------
 Resource: no/en/core.cljc:136:1
--------------------------------------------------------------------------------
 133 |   [s]
 134 |   (parse-number s #(#?(:clj Long/parseLong :cljs js/parseInt) %1)))
 135 | 
 136 | (defn parse-double
-------^------------------------------------------------------------------------
 parse-double already refers to: cljs.core/parse-double being replaced by: no.en.core/parse-double
--------------------------------------------------------------------------------
 137 |   "Parse `s` as a double number."
 138 |   [s]
 139 |   (parse-number s #(#?(:clj Double/parseDouble :cljs js/parseFloat) %1)))
 140 | 
--------------------------------------------------------------------------------

esp1 avatar May 29 '22 22:05 esp1

I have fixed this issue. see https://github.com/r0man/cljs-http/pull/137

If the pull request has not been merged for a long time, you can try to use [io.github.ruffnext/cljs-http "0.1.47"]

ruffnext avatar Nov 05 '22 14:11 ruffnext