SpaceX-API icon indicating copy to clipboard operation
SpaceX-API copied to clipboard

Images are being served via imgur which has a restrictive CORS policy

Open lloydjatkinson opened this issue 3 years ago • 4 comments

Hi,

Would it be possible to switch to, for example, imgbox, as shown in the README example anyway? The reason for this is that imgur now does not allow embedding of images without an API key. imgbox does not.

I came across this with getting the mission badge for the upcoming launches endpoint, I have not yet checked every endpoint.

Thanks!

lloydjatkinson avatar Aug 22 '22 00:08 lloydjatkinson

Definitely! I'll throw a script together this weekend to get them all moved over 👍

jakewmeyer avatar Aug 25 '22 23:08 jakewmeyer

@lloydjatkinson Just switched everything over, should be good now 👍

jakewmeyer avatar Aug 27 '22 23:08 jakewmeyer

That's great thank you! I can still see 4 from this API, but its better than the hundreds previous 😁

image

lloydjatkinson avatar Aug 28 '22 00:08 lloydjatkinson

Might been a few lingering cache items at that point, all imgur links appear to be gone now

jakewmeyer avatar Aug 28 '22 19:08 jakewmeyer