styler icon indicating copy to clipboard operation
styler copied to clipboard

Consistent {pkg} notation

Open lorenzwalthert opened this issue 4 years ago • 3 comments

lorenzwalthert avatar Apr 17 '21 09:04 lorenzwalthert

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9f9bdff). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #778   +/-   ##
=========================================
  Coverage          ?   90.62%           
=========================================
  Files             ?       47           
  Lines             ?     2410           
  Branches          ?        0           
=========================================
  Hits              ?     2184           
  Misses            ?      226           
  Partials          ?        0           
Impacted Files Coverage Δ
R/environments.R 100.00% <ø> (ø)
R/io.R 87.75% <ø> (ø)
R/nest.R 100.00% <ø> (ø)
R/style-guides.R 99.39% <ø> (ø)
R/testing-public-api.R 100.00% <ø> (ø)
R/token-create.R 95.91% <ø> (ø)
R/ui-caching.R 100.00% <ø> (ø)
R/ui-styling.R 100.00% <ø> (ø)
R/utils-cache.R 100.00% <ø> (ø)
R/addins.R 15.29% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f9bdff...960279f. Read the comment docs.

codecov-commenter avatar Apr 17 '21 09:04 codecov-commenter

@lorenzwalthert This has deviated significantly from main. Are you still planning to work on this?

IndrajeetPatil avatar Nov 08 '22 09:11 IndrajeetPatil

No, kind of waiting for the respective tidyverse style issue to be addressed.

lorenzwalthert avatar Nov 08 '22 10:11 lorenzwalthert

No, kind of waiting for the respective tidyverse style issue to be addressed.

Which issue are you referring to?

IndrajeetPatil avatar Apr 21 '24 17:04 IndrajeetPatil

https://github.com/tidyverse/style/issues/180.

But yeah this has so many merge conflicts that we will start from scratch again I guess.

lorenzwalthert avatar Apr 21 '24 18:04 lorenzwalthert