styler icon indicating copy to clipboard operation
styler copied to clipboard

Wrap long lines (follow up)

Open lorenzwalthert opened this issue 6 years ago • 1 comments
trafficstars

Follow-up of #414.

lorenzwalthert avatar Apr 22 '19 15:04 lorenzwalthert

Status of this PR:

  • worked at some point but not for all cases I experimented with.
  • probably there are merge conflicts by now, has to be rebased on master. I think this PR is conceptually a good approach, but the implementation may need substantial rework.
  • After the experience with caching and stylerignore feature in v1.3.0, I think we should make this an opt-in feature governed by an R option for a few releases. Also, styler will be slower when this is turned on.
  • as this is considered to be invasive, it should only take effect for strict = TRUE.
  • Not sure if we should takle the problem for different expression types individually instead of aiming for a general solution. Prime candidate: function calls. I think the overwhelming majority of long lines are function calls (potentially nested in assignment expressions). Related: #544.

I am not going to contribute code to this feature soon though.

lorenzwalthert avatar Mar 21 '20 06:03 lorenzwalthert