lintr icon indicating copy to clipboard operation
lintr copied to clipboard

Handle comparison to negative non-integer in expect_identical_linter

Open Bisaloo opened this issue 1 year ago • 1 comments

Fix #2410

Bisaloo avatar Dec 10 '23 13:12 Bisaloo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.65%. Comparing base (fc2268f) to head (1b4b058). Report is 7 commits behind head on main.

:exclamation: Current head 1b4b058 differs from pull request most recent head 79334a8

Please upload reports for the commit 79334a8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
+ Coverage   98.15%   98.65%   +0.49%     
==========================================
  Files         125      125              
  Lines        5738     5631     -107     
==========================================
- Hits         5632     5555      -77     
+ Misses        106       76      -30     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 10 '23 13:12 codecov-commenter

All tests are now passing. I'm not super happy about the complexity of this xpath but I can't think of something simpler at the moment. Please let me know if you have a better way in mind.

Bisaloo avatar Jun 07 '24 11:06 Bisaloo

https://github.com/r-lib/lintr/issues/963 may be a good way to simplify the code eventually.

Bisaloo avatar Jun 07 '24 12:06 Bisaloo