Maximilian Luz

> Got a keyerror for reg-disable. I opened the [script](https://github.com/linux-surface/surface-aggregator-module/blob/master/scripts/ssam/evreg.py) and found that it had apparently been replaced by reg1-disable and reg2-disable Ah yeah sorry, should have checked that. The...

> This section looks promising? Yeah, that's basic upstream DT support, thanks to @konradybcio.

Touchscreen is likely similar to the SPX and connected via HID-over-SPI: https://github.com/linux-surface/kernel/blob/03d94f64f9988b4f01cf7f971d24c3fdd160bb3e/arch/arm64/boot/dts/qcom/sc8180x-surface-pro-x.dts#L1115-L1139. Meaning it sends HID data for single-touch and raw heatmap data over HID that needs IPTS for additional...

> Result: Hoped this would fix the 'FileNotFoundError: [Errno 2] No such file or directory: '/dev/surface/aggregator'' error, but no change. You will need to manually `modprobe surface_aggregator_cdev` to load the...

> Results are below. Seems like the most notable portion is `$ sudo python3 ssam/hid.py hid-get-descriptor 1 1 0 [9, 33, 17, 1, 0, 1, 34, 155, 0]` Yeah, that...

According to https://github.com/linux-surface/acpidumps/blob/master/surface_laptop_7_qcom/ssdt.dsl#L1480 it looks like a HID-over-SPI device. So it probably needs a similar addition as I linked for the SPX above. You can trace the SPI node back...

Yeah. Basically the romulus dts inherits from the SoC dtsi and what you pasted here is the base SPI node. You'd need to reference and enable it like [here](https://github.com/linux-surface/kernel/blob/03d94f64f9988b4f01cf7f971d24c3fdd160bb3e/arch/arm64/boot/dts/qcom/sc8180x-surface-pro-x.dts#L1115-L1139). I...

> When I tried to build, I got the error: I think this commit caused that: https://github.com/torvalds/linux/commit/a5a056c8d2ba60017dffb914bdf92c5562defc48. Removing `select HID` should be the correct way. You can check the produced...

It could also be that it's just not loaded, if the DT doesn't specify the device... AFAIK `lsmod` only shows loaded modules? So maybe try `modinfo spi-hid`.

@ocean1ee1 Thanks for tracking this down! I guess we can patch that back in, we're already adding some debian/ubuntu specific patches to the packaging side anyway. I'll have a look...