qwik-ui icon indicating copy to clipboard operation
qwik-ui copied to clipboard

class-variance-authority is not installed by the CLI

Open Balastrong opened this issue 1 year ago • 1 comments

As Is

Not a blocker but maybe it's worth mentioning, on a fresh project after installing qwik-ui and the button component, I noticed class-variance-authority was not installed.

Repro Steps

  1. Create a new qwik project
  2. Install qwik-ui pnpm dlx qwik-ui init
  3. Install the button component pnpm qwik-ui add button

To Be

Since the button component has an import from class-variance-authority I was expecting the cli to automatically add it on package.json, either on the lib install or when adding a component (e.g. button) that uses it.

Balastrong avatar Apr 08 '24 20:04 Balastrong

+1

LazyClicks avatar May 14 '24 22:05 LazyClicks

thanks @Balastrong !

@maiieul did you add it as a dependency to the styled component? or should it be installed separately?

shairez avatar May 29 '24 23:05 shairez

@shairez It should be installed with the cli. Do we simply need to add it to dependencies on the styled kit?

maiieul avatar May 31 '24 06:05 maiieul

I would also like to add that @qwikest/icons and tailwindcss-animate are also not installed as well.

brandiqa avatar Jun 21 '24 09:06 brandiqa