libQuotient icon indicating copy to clipboard operation
libQuotient copied to clipboard
verified publisher icon quotient-im

Add support for xyz.amorgan.blurhash in ImageContent

Open redstrate opened this issue 2 years ago • 4 comments

This adds an optional key to ImageContent, for displaying a blurhash on the client before an image is loaded.

Example consumer in Neochat: https://invent.kde.org/network/neochat/-/merge_requests/1151

redstrate avatar Aug 19 '23 18:08 redstrate

I'd be happy to see the blurhash generation code in the library too - would you mind moving it over here from the NeoChat MR? :)

KitsuneRal avatar Aug 19 '23 22:08 KitsuneRal

I'd be happy to see the blurhash generation code in the library too - would you mind moving it over here from the NeoChat MR? :)

Sure can!

redstrate avatar Aug 22 '23 19:08 redstrate

Okay the blurhash implementation has been moved here, will update the NeoChat MR accordingly

redstrate avatar Oct 19 '23 19:10 redstrate

Okay I took a look at it once again and the same question from above holds: what's the point of having the protected interface and the whole class in fact? Why not a namespace with two functions and the rest pulled into the .cpp backend?

KitsuneRal avatar Jul 30 '25 17:07 KitsuneRal