tantivy icon indicating copy to clipboard operation
tantivy copied to clipboard

Published 20 hours ago • verified publisher icon quickwit-oss

feat: cardinality aggregation

Open raphaelcoeffic opened this issue 1 year ago • 3 comments

Implements #2248

raphaelcoeffic avatar Apr 01 '24 13:04 raphaelcoeffic

@PSeitz I leave you the rest of the code review. Also can you open a ticket to one or another isolate aggregation? I think it is a bit overkill for most tantivy user to have to depend on hyperloglog.

fulmicoton avatar Apr 02 '24 07:04 fulmicoton

Looks good so far, I left some comments.

I don't think hyperloglog is really big on its own, but all aggregations together may cost quite a bit if you don't use it.

PSeitz avatar May 28 '24 09:05 PSeitz

Looks good so far, I left some comments.

Thx @PSeitz, it should be all fixed now.

raphaelcoeffic avatar Jun 10 '24 08:06 raphaelcoeffic

Thanks @raphaelcoeffic !

PSeitz avatar Jun 30 '24 23:06 PSeitz