tantivy
tantivy copied to clipboard
Inconsistent API implementation of BytesOptions, TextOptions, and NumericOptions
-
The fieldnorms function is implemented differently in the following places. https://github.com/quickwit-oss/tantivy/blob/main/src/schema/bytes_options.rs#L48
https://github.com/quickwit-oss/tantivy/blob/main/src/schema/numeric_options.rs#L74
https://github.com/quickwit-oss/tantivy/blob/main/src/schema/text_options.rs#L120
The implementation for BytesOptions and TextOptions should have
&& self.indexedjust like NumericOptions -
Setter functions don't take a boolean argument for set_fieldnorm in NumericOptions, BytesOptions https://github.com/quickwit-oss/tantivy/blob/main/src/schema/text_options.rs#L114
https://github.com/quickwit-oss/tantivy/blob/main/src/schema/bytes_options.rs#L77
https://github.com/quickwit-oss/tantivy/blob/main/src/schema/numeric_options.rs#L108
I will fix the inconsistencies, once someone can confirm here
I will fix the inconsistencies, once someone can confirm here
Thanks for the links, yes they are inconsistent and should be fixed