tantivy-py icon indicating copy to clipboard operation
tantivy-py copied to clipboard

Support for all Tantivy query methods

Open theblackcat102 opened this issue 5 years ago • 10 comments

Will there be support for other query method such as PhraseQuery, FuzzyTermQuery, RangeQuery?

theblackcat102 avatar Mar 12 '20 22:03 theblackcat102

I don't have any plans to work on this myself, at least not for now.

Contributions of course are always welcome.

poljar avatar Mar 14 '20 11:03 poljar

Hi,

How to contribute then ? I don't see python code in the repo.

fuzzy matching absence is a no go for using tantivy in python even though tantivy seems very powerful.

Many thanks, Guillaume

GuillaumePressiat avatar Nov 26 '23 17:11 GuillaumePressiat

Hi guys! I'd like to contribute to this issue. For a good starter, I've already opened #175. ;) Could anyone review it?

mocobeta avatar Dec 17 '23 11:12 mocobeta

#175 has been merged. I think either we should have a checklist of remaining query methods on this issue, or we create new separate enhancement issues for each of the remaining ones. Which is better?

cjrh avatar Dec 30 '23 23:12 cjrh

There are several Query classes in Tantivy. https://docs.rs/tantivy/latest/tantivy/query/trait.Query.html#impl-Query-for-Box%3Cdyn+Query%3E

I think having a checklist is a great idea on this issue.

mocobeta avatar Dec 31 '23 06:12 mocobeta

I made a simple checklist to support all Tantivy queries (I don't have permission to edit the issue description.)

  • [x] AllQuery (https://github.com/quickwit-oss/tantivy-py/pull/230)
  • [x] BooleanQuery (#243)
  • [x] BoostQuery (#250)
  • [x] ConstScoreQuery (#256)
  • [x] DisjunctionMaxQuery (#244)
  • [ ] EmptyQuery
  • [x] FuzzyTermQuery (#233)
  • [x] MoreLikeThisQuery (#257)
  • [ ] PhrasePrefixQuery
  • [x] PhraseQuery (#234)
  • [ ] RangeQuery
  • [x] RegexQuery (#241)
  • [x] TermQuery (#175)
  • [x] TermSetQuery (#249)

mocobeta avatar Dec 31 '23 08:12 mocobeta

Looks like FuzzyTermQuery has been implemented, but not available in the current release on PyPI. Curious if this project has a cadence for releases. Thanks!

https://github.com/quickwit-oss/tantivy-py/commit/e95a4569d488059ce01f0cea4f1bc4a371f903a0

imaurer avatar Mar 13 '24 20:03 imaurer

Hi @imaurer, we don't have a set cadence of releases unfortunately. @wallies does our releases, I'm sure he'll get around to it within the next week or two.

cjrh avatar Mar 14 '24 15:03 cjrh

@cjrh @imaurer I was hoping tantivy would publish a new release so will could pull in some upstream fixes as well. I'll make a release within the next few days

wallies avatar Mar 14 '24 16:03 wallies

I just submitted a PR that exposes DisjunctionMaxQuery. Hopefully, someone can review and it can make it to the next release as well.

BTW, thanks for this great library!

aecio avatar Apr 22 '24 18:04 aecio