quickwit icon indicating copy to clipboard operation
quickwit copied to clipboard

Published 20 hours ago • verified publisher icon quickwit-oss

Suspicious unwraps in `members_grpc_addresses_for_service`

Open fmassot opened this issue 3 years ago • 0 comments

Viewed in the cluster implem:

  • ~~https://github.com/quickwit-oss/quickwit/blob/main/quickwit-cluster/src/cluster.rs#L257-L258~~ (false alert thanks @guilload)
  • https://github.com/quickwit-oss/quickwit/blob/main/quickwit-cluster/src/cluster.rs#L243-L245

I would remove them, or if there are ok (but I'm not convinced at all) this would need some comments.

fmassot avatar Jul 27 '22 19:07 fmassot