quickfixj
quickfixj copied to clipboard
`Session#verify` is misleading
From the name verify you could be excused from thinking that all it does is a form of validation.
Indeed the majority of the message does do this, checking sequence numbers and so-on.
But the last line is to call fromCallback
https://github.com/quickfix-j/quickfixj/blob/974dc7f358b7cdd74ad70e351d18031b66631a0b/quickfixj-core/src/main/java/quickfix/Session.java#L1872
This radically expands the verify method to actually being the point of entry to the Application for FIX traffic.
I can see two options
- Rename
verifytoverifyAndProcessMessage - Move the
fromCallbackcall outside verify and restructuring callers.
Thanks @philipwhiuk , in my opinion I'd go for option 2. Since these are internal methods it shouldn't be a problem.