quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Published 20 hours ago • verified publisher icon quickfix-j

Enhanced logic around the `ValidateFieldsOutOfOrder` setting

Open jacques0803 opened this issue 3 years ago • 5 comments

Enhancements made to correctly parse Header fields found in the body of a message.

Fixes #468

jacques0803 avatar Apr 19 '22 05:04 jacques0803

Hi @chrjohn Would you mind approving the running of the workflows. As a first-timer, I need a maintainer to initiate the CI workflows. Regards

jacques0803 avatar Apr 26 '22 10:04 jacques0803

Hi @chrjohn

This pull request is now ready for review. All checks have passed. Please let me know if you have any concerns with the changes I've made.

Kind regards

jacques0803 avatar Apr 27 '22 11:04 jacques0803

Hi @jacques0803 thanks for the PR and the extensive test. Would you mind creating a test for a FIX version below FIX5.0 (i.e. where there is no separate session dictionary)? Thanks

chrjohn avatar Apr 28 '22 15:04 chrjohn

Hi @jacques0803 thanks for the PR and the extensive test. Would you mind creating a test for a FIX version below FIX5.0 (i.e. where there is no separate session dictionary)? Thanks

Hi @chrjohn Done. Could you please approve the workflows again for me. Regards Jacques

jacques0803 avatar Apr 29 '22 07:04 jacques0803

Hi @chrjohn

Additional unit test case added for pre-FIXT11 and all checks have passed. Ready for your review again.

Regards Jacques

jacques0803 avatar May 01 '22 21:05 jacques0803

Done. Sorry for missing it.

chrjohn avatar Oct 11 '22 08:10 chrjohn

Thank you @chrjohn

Would you mind merging the Pull Request as well, as I do not have write access on the repository.

Regards Jacques

jacques0803 avatar Oct 11 '22 10:10 jacques0803

Hi @jacques0803 , currently in the process of reviewing/merging/creating some PRs. Will merge yours in due course.

chrjohn avatar Oct 12 '22 08:10 chrjohn