quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Add limit on messages pending resend

Open philipwhiuk opened this issue 3 years ago • 1 comments
trafficstars

Fixed #477

philipwhiuk avatar Mar 29 '22 09:03 philipwhiuk

Hi @philipwhiuk , I've just merged #380 . So it should be a matter of creating your own queue implementation with an enqueue method similar to this:

public void enqueue(int sequence, Message message) {
    if (backingMap.size() < maxMessagesQueuedWhilePendingResend || maxMessagesQueuedWhilePendingResend == -1) {
        backingMap.put(sequence, message);
    }
}

Do you think it is OK to close this PR then? Would you like to submit a PR with a queue implementation that is limited in size? Thanks, Chris.

chrjohn avatar Sep 12 '22 11:09 chrjohn

Hi Chris, Yeah, I'll look at creating a PR for this.

philipwhiuk avatar Jul 26 '23 15:07 philipwhiuk