quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Add affected `socketAddress` to `SessionStateListener#onConnectException`

Open stasal opened this issue 3 years ago • 3 comments
trafficstars

Please, consider adding socketAddress to exception passed as argument for quickfix.SessionStateListener#onConnectException

This information is available in quickfix.mina.initiator.IoSessionInitiator.ConnectTask#handleConnectException method and it can be very useful for troubleshooting outside the library

stasal avatar Dec 06 '21 14:12 stasal

sounds like a sensible enhancement. Are you able to submit a PR for this?

chrjohn avatar Dec 06 '21 16:12 chrjohn

@chrjohn Sure! Opened a pull request, take a look. Maybe I need to implement some tests for new code?

stasal avatar Dec 07 '21 08:12 stasal

Thanks for the PR, let's continue the discussion there.

chrjohn avatar Dec 07 '21 22:12 chrjohn