quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Remove field duplication on insertion

Open charlesbr1 opened this issue 10 years ago • 0 comments
trafficstars

All the inserted fields are duplicated : they are converted to StringField, then added to the treeMap. We can remove a lot of allocations by avoiding this behavior. Unless there is a specific reason for this purpose, it seems to works fine without this.

The setField(DoubleField field) method got a different implementation from the other because we do not want to allocate a Double instance if the field was built using a double. Hence no null field check are performed for this one.

Furthermore, the setGroupCount() method allocated the string "1" when there is only one group, this is not efficient.

charlesbr1 avatar Aug 01 '15 06:08 charlesbr1