quickfixj icon indicating copy to clipboard operation
quickfixj copied to clipboard

Published 20 hours ago • verified publisher icon quickfix-j

Add extra options to session class

Open philipwhiuk opened this issue 6 years ago • 5 comments

We have long had some internal settings that I feel like upstream will benefit from (also it makes my life easier).

AllowPosDup

PossDupFlag is set when resending messages. Currently it's automatically removed by QFJ. This PR makes two changes:

  • It exposes a method 'sendNoChange' which never removes these settings. This is useful when resending messages from a cache or from an application store behind QFJ.
  • It exposes a session setting 'AllowPosDup' that means we never remove the flag. This has been useful on occasion - primarily when a QFJ application is acting as purely a pass-through/monitoring hop.

Fix41ResendRequestAsFix42

  • Some sessions claim to be FIX.4.1 but actually send FIX.4.2 format ResendRequests. This is useful for that. Quite common in less formalised trading networks where quite frankly the begin string is often just misleading.

philipwhiuk avatar Aug 16 '19 15:08 philipwhiuk

I'll have to work out how to handle it if we rename them. We can probably deprecate and map the old values in our code before passing them to QFJ. I'm open to renaming it and making it more general.

In terms of sending that does make sense. I'll see if we have any active usage of it these days (it's been internal for way way too long) and see whether we can try to see whether it was intentionally only done on one side.

I'll try to write some more tests for both pieces before we merge this in :)

philipwhiuk avatar Aug 20 '19 14:08 philipwhiuk

Hi @chrjohn,

What needs doing on this PR? I'm happy to help moving it forward

Thanks

esanchezros avatar May 14 '21 11:05 esanchezros

Hi @esanchezros. I'll update this tomorrow with some tests and the changes from Chris and then hopefully it can be merged :)

philipwhiuk avatar May 20 '21 20:05 philipwhiuk

Hi @philipwhiuk, I thought this PR was abandoned and created a new one just for allowing PossDupFlag in send https://github.com/quickfix-j/quickfixj/pull/395 If you and @chrjohn are okay with it perhaps it can be reviewed/merged and you could create a separate one for the other feature? Thanks Ed

esanchezros avatar May 21 '21 07:05 esanchezros

Hi @philipwhiuk @esanchezros

personally I would prefer to have each feature in a single PR, so if it is OK with you (@philipwhiuk) then I would be happy if we could proceed with #395 for the PossDup thing and leave this PR for the FIX4.1/4.2 Resend option.

What do you think? Thanks, Chris.

chrjohn avatar May 21 '21 22:05 chrjohn