VegaLite.jl icon indicating copy to clipboard operation
VegaLite.jl copied to clipboard

Add html output for documenter

Open noahrhodes opened this issue 8 months ago • 1 comments

closes #443

The addition of Base.showable(m::MIME"text/html", v::VLSpec) = isdefined(Main, :PlutoRunner) in #401 meant that when Documenter checked if html output was supported for VLSpec, pluto wasn't loaded so it did not support creating the interactive examples.

Adding isdefined(Main, :makedocs) is a similar method to add support for the interactive documentation examples.

This fix is needed for the documentation examples in my own package, https://wispo-pop.github.io/PowerPlots.jl/stable/

I would appreciate a quick acceptance and tagging of a new version, as the interactively issue has been an annoyance for over 1.5 years now.

noahrhodes avatar Mar 29 '25 22:03 noahrhodes

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.92%. Comparing base (5e6ad7c) to head (4edeacc). Report is 10 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   78.92%   78.92%           
=======================================
  Files          12       12           
  Lines         427      427           
=======================================
  Hits          337      337           
  Misses         90       90           
Flag Coverage Δ
unittests 78.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 29 '25 23:03 codecov-commenter