quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Add traceresponse header to HTTP responses

Open wottop opened this issue 1 year ago • 3 comments

https://github.com/quarkusio/quarkus/issues/11931

wottop avatar Aug 19 '24 19:08 wottop

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

quarkus-bot[bot] avatar Aug 19 '24 19:08 quarkus-bot[bot]

Should it be done in dev mode only ?

sberyozkin avatar Aug 20 '24 09:08 sberyozkin

@wottop Are you thinking on continuing the work on this issue? Some considerations:

  1. The response header should not be inserted by default. A new property is needed with default value to false.
  2. This needs to be developed for quarkus-rest quarkus-resteasy-classic and vertx routes.
  3. We need tests.

brunobat avatar Oct 17 '24 14:10 brunobat

@brunobat What should we do here?

cescoffier avatar Nov 10 '24 17:11 cescoffier

Like it is, we cannot accept the PR and because @wottop hasn't addressed the comments I'm closing the PR. We can re-open it if we hear any news.

brunobat avatar Nov 11 '24 16:11 brunobat

I tried that code in one of my projects. Unfortunately it also won't address resources retiring Multi responses (see also #44898). So I guess there is some alternative implementation needed to fully support setting the traceresponse.

dastrobu avatar Dec 03 '24 14:12 dastrobu