Rest Client: Add property to skip hostname verification

[Sgitario]

trafficstars

Before these changes, we only can disable the hostname verification in Rest Client classic by providing the following property:

quarkus.rest-client.extensions-api.hostname-verifier=io.quarkus.restclient.NoopHostnameVerifier

However, this is not working in Rest Client reactive because setting a hostname verifier strategy is not supported by the Vert-x HTTP Client.

With these changes, we have added a new property in both Rest Client classic and reactive quarkus.rest-client.extensions-api.verify-host=true or false. In Rest Client classic, when disabling the verify host, internally it will add the NoopHostnameVerifier strategy. In Rest Client reactive, it will properly configure the Vert.x HTTP client to disable the hostname verification. Therefore, in both Rest Client implementations (classic and reactive), the behaviour is the same.

Fix https://github.com/quarkusio/quarkus/issues/27901

[geoand]

@famod mind trying this out?

[famod]

@geoand I'd love to, but right now I'm standing in the middle of chaos because on the weekend we're finally relocating to our new house. So better not wait for me.

[geoand]

Hope all goes well with the move :)

[geoand]

@Chexpir would you like to test this before we merge it?

[Chexpir]

@geoand thanks for the proposition, no need to test it. I've reviewed the code and I trust that it will work! Anyway, it will be useful to know the process to build and test github branches, it might become handy in the future, as we are into Quarkus for the long term! (I have searched and could not find anything).

[geoand]

I would say that the easiest way to checkout a Pull Request is following this. Once that is done, you can build it locally by following this.

[geoand]

@Chexpir were you able to test this one?

[geoand]

Were are we with this one?

I personally think we should get it in

[Sgitario]

Were are we with this one?

I personally think we should get it in

My +100 to get it in.

[cescoffier]

My last comment was to make sure we clearly say in the doc that skipping host name verification should not be used in prod ('use it to your own risk')

[geoand]

We should 100% add that

[Sgitario]

PR updated with adding this warning to the docs.

[quarkus-bot[bot]]

---

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

---

Failing Jobs - Building d1280c2d18729f488afc20a63eb036b26abfbe71

Status	Name	Step	Failures	Logs	Raw logs
:heavy_check_mark:	JVM Tests - JDK 11
:heavy_check_mark:	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 MacOS M1		:warning: Check →	Logs	Raw logs
:heavy_check_mark:	JVM Tests - JDK 18

[Sgitario]

Any updates on this pull request? I would like to proceed to merge it if everybody agrees.

[fasuke85]

Hi, it would be awsome if you merged this PR 😄

[oven]

@Sgitario This issue is a blocker for us because we have to communicate with an HTTPS service over an ssh tunnel. Please merge :)

[geoand]

@gsmet any last words or should I dismiss the old review?

[geoand]

Since the last CI run of this was a while ago, I rebased onto main.

[quarkus-bot[bot]]

Failing Jobs - Building 941d3a6f7a1857d01a1a2b0eada67e3628895c0c

Status	Name	Step	Failures	Logs	Raw logs
:heavy_check_mark:	JVM Tests - JDK 11
:heavy_check_mark:	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 MacOS M1	Set up runner	:warning: Check →	Logs	Raw logs
:heavy_check_mark:	JVM Tests - JDK 18