quarkus-scala3 icon indicating copy to clipboard operation
quarkus-scala3 copied to clipboard

Read Scala options from pom.xml

Open carlosedp opened this issue 1 year ago • 1 comments

This PR adds POM parsing to fetch Scala compiler options defined in the scala-maven-plugin configuration.

The environment variable still have preference if passed.

carlosedp avatar Dec 21 '23 21:12 carlosedp

Thanks for the comment @gsmet ... I've revisited this and done a couple tests and found the compiler arguments set in scala-maven-plugin -> configuration -> args already applies to the dev mode:

Before:

❯ quarkus dev
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------< org.acme:scala3-quarkus-quickstart >-----------------
[INFO] Building scala3-quarkus-quickstart 1.0.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- quarkus:3.7.1:dev (default-cli) @ scala3-quarkus-quickstart ---
[INFO] Invoking scala:4.8.1:add-source (scala-compile-first) @ scala3-quarkus-quickstart
[INFO] Invoking scala:4.8.1:compile (scala-compile-first) @ scala3-quarkus-quickstart
[INFO] compiling 17 Scala sources to /Users/cdepaula/repos/scala/scala3-quarkus-quickstart/target/classes ...
[WARNING] /Users/cdepaula/repos/scala/scala3-quarkus-quickstart/src/main/scala/org/acme/GreetingResource.scala:5:13: unused import
[WARNING] one warning found
[INFO] done compiling
[INFO] compile in 8.0 s
[INFO] Invoking resources:3.3.1:resources (default-resources) @ scala3-quarkus-quickstart
...

After adding <arg>-Werror</arg> to pom.xml:

❯ quarkus dev
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------< org.acme:scala3-quarkus-quickstart >-----------------
[INFO] Building scala3-quarkus-quickstart 1.0.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- quarkus:3.7.1:dev (default-cli) @ scala3-quarkus-quickstart ---
[INFO] Invoking scala:4.8.1:add-source (scala-compile-first) @ scala3-quarkus-quickstart
[INFO] Invoking scala:4.8.1:compile (scala-compile-first) @ scala3-quarkus-quickstart
[INFO] compiling 17 Scala sources to /Users/cdepaula/repos/scala/scala3-quarkus-quickstart/target/classes ...
[ERROR] /Users/cdepaula/repos/scala/scala3-quarkus-quickstart/src/main/scala/org/acme/GreetingResource.scala:5:13: unused import
[ERROR] one error found
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.611 s
[INFO] Finished at: 2024-02-02T15:12:19-03:00
[INFO] ------------------------------------------------------------------------

So I understand the change in this PR and the suggestion you made is not needed. Right?

carlosedp avatar Feb 02 '24 18:02 carlosedp