quarkus-langchain4j icon indicating copy to clipboard operation
quarkus-langchain4j copied to clipboard

Published 20 hours ago • verified publisher icon quarkiverse

Updates to avoid code duplication

Open karesti opened this issue 1 year ago • 4 comments

This Pr is related to this one

https://github.com/langchain4j/langchain4j/pull/845

karesti avatar Mar 27 '24 15:03 karesti

I created a PR in langchain4j to avoid duplication of code

What do you think about this ?

karesti avatar Mar 27 '24 15:03 karesti

You're in charge of the Infinispan stuff, so whatever you think is best :)

geoand avatar Mar 27 '24 15:03 geoand

@geoand I was also thinking overall strategy concerning other integrations, since the code is duplicated and the effort seems high

karesti avatar Mar 27 '24 16:03 karesti

Sure, but we'll see tackle it on a per case basis

geoand avatar Mar 27 '24 16:03 geoand