empyrical icon indicating copy to clipboard operation
empyrical copied to clipboard

Remove yahoo finance

Open twiecki opened this issue 8 years ago • 8 comments
trafficstars

Yahoo finance has been discontinued for good. Google is a fallback (albeit a bad one) but there's no reason to display a warning and confuse users: https://github.com/quantopian/pyfolio/issues/478#event-1345024064

twiecki avatar Nov 16 '17 13:11 twiecki

Would it be correct to say that all that needs rewriting is this function in utils.py (and any other docstrings here and there)?

That sounds straightforward; would you like me to put together a PR?

eigenfoo avatar Nov 17 '17 02:11 eigenfoo

@eigenfoo Correct.

twiecki avatar Nov 17 '17 14:11 twiecki

It would be great to have an alternative that goes back further in time. We can probably use the yahoo SPY returns for the past, and then forward-fill with the ones from google.

twiecki avatar Nov 17 '17 14:11 twiecki

There's the IEX exchange API if it helps, and it requires no registration:

https://iextrading.com/developer/docs/#stocks

appletonwebb avatar Jan 16 '18 12:01 appletonwebb

@twiecki I replaced Yahoo Finance with Quandl as shown here. Would you like me to update the default to use Quandl instead?

jaycode avatar Mar 25 '18 20:03 jaycode

@jaycode Yes, that seems like a more stable source!

twiecki avatar Mar 25 '18 21:03 twiecki

@twiecki Done, please resolve conflicts here: https://github.com/quantopian/empyrical/pull/89

jaycode avatar Mar 26 '18 07:03 jaycode

There is also some minimal updates for Pyfolio module for this to work. See here: https://github.com/jaycode/pyfolio/commit/7ef8d27c4926f7cde2abcf6a15d0950450791633

A working example can be seen here: https://github.com/jaycode/pyfolio/blob/master/pyfolio/examples/single_stock_example.ipynb

jaycode avatar Mar 26 '18 07:03 jaycode