Ishan Goel

Results 138 comments of Ishan Goel

Yup, I’ve other projects now.

I just pushed an update

Found it here: https://github.com/candid82/liner

Ah is this commit what you mean: https://github.com/candid82/liner/commit/8e336a7c0c893df1b4d38a2cfe8ea25e3b0919c4? I will use that fork now. Hooray for open source!

I can confirm it works! Hooray! Are you going to make a PR, @jcburley (the commit being yours) or would you like me to?

I think at least this one change would be a good addition to the original library. @peterh, would you be interested in such a change? Could you expand on what...

I guess making a PR and then letting Peter decide to merge it or not would work too. In that case, would you like to make a PR? Also, is...

I don't see a way to set the mode...? Besides, how do you feel about having this as default behavior?

Hmm but the reason I'm involved in this is _because_ I'm making a [shell](https://github.com/quackduck/lolsh). When raw mode is enabled, programs ran through the shell I'm making can't get any input.