aces icon indicating copy to clipboard operation
aces copied to clipboard

Published 20 hours ago • verified publisher icon quackduck

Crashes upon running encoding with a string with two of the same letter

Open Aversefun opened this issue 1 year ago • 5 comments

image

image

Aversefun avatar May 03 '24 01:05 Aversefun

I have modified the code and added an error to notify the user that the charset contains a duplicated character, shall I make it be a warning instead? I will make a PR once you answer

xplshn avatar May 03 '24 02:05 xplshn

Wow thanks, I was thinking maybe either it automatically changing the string to not have duplicate characters, but a warning works

Aversefun avatar May 03 '24 02:05 Aversefun

The decoding part I haven't checked, truth is I am not very familiar with this project's code, so, I will now check if this same issue happens when decoding or not

xplshn avatar May 03 '24 02:05 xplshn

Well, I didn't break anything it seems

2024-05-02-233334_1112x274_scrot

xplshn avatar May 03 '24 02:05 xplshn

Looks good, thanks!

On Thu, May 2, 2024, 9:34 PM xplshn @.***> wrote:

Well, I didn't break anything it seems

2024-05-02-233334_1112x274_scrot.png (view on web) https://github.com/quackduck/aces/assets/114888778/e05f5c9c-8210-4701-adbf-42fc2740ed74

— Reply to this email directly, view it on GitHub https://github.com/quackduck/aces/issues/2#issuecomment-2092035774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATOOUFTI3GLGGZBNPNJBZJ3ZALZUFAVCNFSM6AAAAABHEXBBCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGAZTKNZXGQ . You are receiving this because you authored the thread.Message ID: @.***>

Aversefun avatar May 03 '24 12:05 Aversefun