Quy Tang
Quy Tang
@qvalentin you're right. Using `currentThreadId` like that won't work as the initial value is undefined and the connection headers are not updated after the initial socket initialization. I've tested this...
Yeah, I'm planning to do that when time permits. Will need to add some test cases too
> Please submit a PR! PR is created, pls review.
> This looks really nice, will run a couple more tests before merging. Thank you for your contribution! @willydouhard I've resolved the merge conflict with the latest version. Please review...
@willydouhard any chance this can get reviewed soon? :)
Thanks @dokterbob and welcome onboard if I haven't said so :). Glad to know that the team is growing to make chainlit even more awesome. This PR was done a...
> @qtangs Thanks for your patience and contrib! ❤️ Wonderful. So glad that this still works. Thanks @dokterbob!
This is how it looks with 3 videos from the test: https://github.com/Chainlit/chainlit/blob/51be1a324fac1f82d1376fa95461589624daaf14/cypress/e2e/video_element/main.py#L6-L41
Yes, that's already the case, react-player can auto detect based on url. The player config is optional, it's added to show how to customize settings like autoplay and start time.
Ah, there's a branch conflict now. I'll fix it but can @willydouhard or someone from the team review this soon so we avoid new conflicts?