logback icon indicating copy to clipboard operation
logback copied to clipboard

Remove Unused comment in Logger

Open ruanwenjun opened this issue 1 year ago • 2 comments

ruanwenjun avatar Oct 13 '24 13:10 ruanwenjun

Your PR title is "Remove Unused comment in LoggerContext", but the comment you removed is in Logger. In LoggerContext you removed redundant casting and type information and unused imports. These codebase modernization activities could be done en masse using tools, but don't seem to be a project priority. I'd be inclined to separate or discard inconsequential changes. In Logger you do many things other than remove a comment. I suggest focusing your PR and not neglecting the PR title and description. Maintainers appreciate an accurate title and overview.

Thanks suggestions, this help me not only on this PR but in the future work. So I need to separate this PR and change the title to Remove Unused comment in Logger and focus on only remove the comment

/**
 * The default size of child list arrays. The JDK 1.5 default is 10. We use a
 * smaller value to save a little space.
 */

ruanwenjun avatar Oct 15 '24 04:10 ruanwenjun

No guarantee to get attention of maintainers, but that sounds like a focused PR to me. I encourage you to read the contribution guidelines. Wish you luck.

mches avatar Oct 15 '24 07:10 mches