gradle-git-versioning-plugin icon indicating copy to clipboard operation
gradle-git-versioning-plugin copied to clipboard

Convert Gradle build config to Kotlin

Open aSemy opened this issue 3 years ago • 4 comments

Converts the build files to use the Kotlin DSL

Additionally

  • bumps Gradle to 7.6
  • enables Gradle Build & Configuration cache (improved build speeds, on CI & also when switching branches locally)
  • uses centralised repo definitions https://docs.gradle.org/7.6/userguide/declaring_repositories.html#sub:centralized-repository-declaration
  • Sets up Java Toolchain https://docs.gradle.org/7.6/userguide/toolchains.html

⚠️ Note that the git history of the build.gradle and settings.gradle files might be lost! It's difficult to get Git to recognise that a file has changed name and the content has also significantly changed. You might want to repeat the two commits https://github.com/qoomon/gradle-git-versioning-plugin/commit/a56e77e8c1a414d4311bb99822a5dad71c845057 https://github.com/qoomon/gradle-git-versioning-plugin/commit/7bc7f0c1f0225ff5e1c30f84a41209104011553f on the master branch if you want to keep the Git history

aSemy avatar Oct 25 '22 16:10 aSemy

hey @qoomon, I see you've approved this PR, when did you want to merge it? Is there something more that I can do?

aSemy avatar Dec 21 '22 16:12 aSemy

hi @aSemy sorry I was on a long vacation. I'll probably merge it between the holidays.

qoomon avatar Dec 23 '22 08:12 qoomon

@qoomon No problem, take your time :) Let me know if I can help or adjust anything.

aSemy avatar Dec 23 '22 10:12 aSemy

Hi @qoomon @aSemy I've stumbled across this project and saw that this PR has been open for a while.

I don't really know how to introduce myself except that I like this plugin and would like to help improve it :)

Anything I can do to help get this PR across the finish line?

tacascer avatar Aug 11 '23 02:08 tacascer