server-side-extension icon indicating copy to clipboard operation
server-side-extension copied to clipboard

Dangerous function call

Open djo-it opened this issue 5 years ago • 0 comments

Hi,

I've found some little issues in your example code. At

https://github.com/qlik-oss/server-side-extension/blob/c500be88a47c3ec35b6b798d20b9867f9761211c/examples/cpp/basic_example/basic_example.cc#L126

and

https://github.com/qlik-oss/server-side-extension/blob/c500be88a47c3ec35b6b798d20b9867f9761211c/examples/cpp/basic_example/basic_example.cc#L167

In this case it would be more safe to use the ParseFromArray function because the data can contain zero bytes which will result in a parse error. This caused some problems in our sse because we are evaluating the metadata.

Kind regards, Daniel John

djo-it avatar Jan 02 '20 13:01 djo-it