qiskit-optimization icon indicating copy to clipboard operation
qiskit-optimization copied to clipboard

Add MPS and GZ support in `translators`

Open dthuerck opened this issue 1 year ago • 3 comments

✅ I have added the tests to cover my changes. ✅ I have updated the documentation accordingly. ✅ I have read the CONTRIBUTING document.

Summary

See issue #582: This PR succeeds #581, having moved lp/mps/gz IO functions into translators.

Details and comments

lp functions in QuadraticProgram have been marked as deprecated. Tests and Tutorials have been updated to use the file_io.

dthuerck avatar Dec 27 '23 15:12 dthuerck

Pull Request Test Coverage Report for Build 8389542132

Details

  • 93 of 95 (97.89%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 93.089%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/translators/file_io.py 77 79 97.47%
<!-- Total: 93 95
Totals Coverage Status
Change from base Build 8048858331: 0.06%
Covered Lines: 4580
Relevant Lines: 4920

💛 - Coveralls

coveralls avatar Dec 27 '23 15:12 coveralls

@woodsp-ibm Thanks for the hints! Should be all done by now, release note is there.

dthuerck avatar Feb 05 '24 11:02 dthuerck

Thanks for the extensive comments, @woodsp-ibm ! I added test cases for the deprecated functions and updated the docs accordingly.

dthuerck avatar Mar 22 '24 11:03 dthuerck

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: woodsp-ibm
:white_check_mark: dthuerck
:x: Daniel Thuerck


Daniel Thuerck seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 06 '24 20:11 CLAassistant