qiskit-optimization icon indicating copy to clipboard operation
qiskit-optimization copied to clipboard

Published 20 hours ago • verified publisher icon qiskit-community

added some code and explanation for how solutions are interpreted using the interpret method, in the tutorial of converters

Open gprs1809 opened this issue 3 years ago • 4 comments

Summary

Details and comments

gprs1809 avatar Jun 12 '22 03:06 gprs1809

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 12 '22 03:06 CLAassistant

Thanks. I take a look at it.

t-imamichi avatar Jun 21 '22 08:06 t-imamichi

Pull Request Test Coverage Report for Build 2580502392

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.432%
Totals Coverage Status
Change from base Build 2579728355: 0.0%
Covered Lines: 4290
Relevant Lines: 4692
💛 - Coveralls

coveralls avatar Jun 21 '22 14:06 coveralls

Hi @t-imamichi and @t-imamichi , thanks a lot! I am just a little confused. Are my additions visible? I guess I see the additions in this commit : 7e4b909 above. Do let me know how it is and if I need to do anything.

gprs1809 avatar Jun 22 '22 05:06 gprs1809

Sorry for taking so long to review this PR. I will take over it and update your PR based on the current code.

t-imamichi avatar Sep 05 '23 11:09 t-imamichi

I updated this PR as follows.

  1. replaced the cells that manually interpret solutions with simply applies interpret because we don't have to show the internal code of interpret.
  2. modified the coeffs of the objective function so that the optimal solution is unique so that the result of the original problem and that of the converted problem are the same.
  3. Fixed the description of the penalty factor of LinearEqualityToPenalty from 1e5 to a value provided by qiskit-optimization. It actually automatically calculate an appropriate value for the penalty term.

t-imamichi avatar Sep 07 '23 03:09 t-imamichi

As this is being updated, I see that this talks about VQE and QAOA in a couple of places, one at the start and one near to the end. Do we want to change this to SamplingVQE ? I know VQE is more known and maybe you want to leave it more generic like that - but of course the qiskit algorithms VQE can no longer used as since the change to primitives.

woodsp-ibm avatar Sep 07 '23 14:09 woodsp-ibm

We refer to VQE as a general algorithm name. So, I think it's fine to leave it. We describe SamplingVQE in 03_minimum_eigen_optimizer.ipynb.

t-imamichi avatar Sep 08 '23 05:09 t-imamichi

We refer to VQE as a general algorithm name. So, I think it's fine to leave it.

Ok, since it docs, if it we do get any feedback its easy enough to adjust at any time.

woodsp-ibm avatar Sep 08 '23 12:09 woodsp-ibm