react-modal-dialog icon indicating copy to clipboard operation
react-modal-dialog copied to clipboard

Update PropTypes for React v15.5

Open GruFFix opened this issue 8 years ago • 10 comments

Updated import React, { PropTypes } from 'react'; to import PropTypes from 'prop-types'; and updated React -> v15.5.4

info: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

GruFFix avatar Apr 19 '17 15:04 GruFFix

@qimingweng can you look my pr please ?

GruFFix avatar Apr 21 '17 13:04 GruFFix

Any reason why this can't be merged?

stevewillard avatar May 13 '17 01:05 stevewillard

Has anyone checked if this can be merged? It'd be nice to upgrade to fiber without having to rewrite this component: http://isfiberreadyyet.com/

natenorberg avatar Jul 26 '17 22:07 natenorberg

I am trying to use this fork @GruFFix

with

"react-modal-dialog": "[email protected]:GruFFix/react-modal-dialog#c6ce77c1676790c1228716b894d5f3f3ccf25ea4",

but when i require it

import { ModalContainer, ModalDialog } from 'react-modal-dialog'

i get

ERROR in ./frontend/app/components/Modal.js
Module not found: Error: Can't resolve 'react-modal-dialog' in '/system/frontend/app/components'
 @ ./frontend/app/components/Modal.js 17:24-53

trying to understand why it is not resolving, if the import gets modified with 'react-modal-dialog/src' it gives problems for other subsequent files that need a loader.

cordoval avatar Aug 08 '17 16:08 cordoval

I made my own fork for now, hope to see this merged ASAP 🥇 👍

cordoval avatar Aug 08 '17 16:08 cordoval

@cordoval This error does exist. Module is not reassembled as for import package

GruFFix avatar Aug 08 '17 17:08 GruFFix

yeah correct, i have fixed that by doing a fork, did not want to complicate my deploy scripts thanks for your reply

cordoval avatar Aug 08 '17 17:08 cordoval

Merge? Where are the maintainers :(

hlolli avatar Sep 12 '17 11:09 hlolli

Please merge. This warning is driving me crazy.

colesimmons avatar Sep 27 '17 11:09 colesimmons

guys do not ask for this, what i did instead was creating my own modal with react-portal, so much way better and more secure for those using CSP, fully recommended. No need for this package, i removed it from package.json

cordoval avatar Sep 27 '17 12:09 cordoval