qiling icon indicating copy to clipboard operation
qiling copied to clipboard

Add debian workflow

Open lovelxc opened this issue 1 year ago • 4 comments
trafficstars

Add linux(debian) for workflow

Checklist

Which kind of PR do you create?

  • [x] This PR only contains minor fixes.
  • [ ] This PR contains major feature update.
  • [ ] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [x] The new code conforms to Qiling Framework naming convention.
  • [x] The imports are arranged properly.
  • [ ] Essential comments are added.
  • [ ] The reference of the new code is pointed out.

Extra tests?

  • [ ] No extra tests are needed for this PR.
  • [ ] I have added enough tests for this PR.
  • [x] Tests will be added after some discussion and review.

Changelog?

  • [ ] This PR doesn't need to update Changelog.
  • [x] Changelog will be updated after some proper review.
  • [ ] Changelog has been updated in my PR.

Target branch?

  • [x] The target branch is dev branch.

One last thing


lovelxc avatar Nov 15 '24 15:11 lovelxc

Sorry no offence. This looks like AI generated?

wtdcode avatar Nov 16 '24 13:11 wtdcode

Sorry no offence. This looks like AI generated?

Yes, but I don't know why some of my modifications weren't written into the build-ci.yml. I intended to finish the build test in my personal branch, but it seems that Qiling hasn't granted the permission for 'Actions' on fork.

lovelxc avatar Nov 16 '24 13:11 lovelxc

Hi,

Looks good, but just not too sure why do we need another distro and both of them are from the same root.

Any specific reason?

xwings avatar Dec 17 '24 06:12 xwings

Hi,

Looks good, but just not too sure why do we need another distro and both of them are from the same root.

Any specific reason?

  1. The default Python versions of the Debian system and the Ubuntu system are different. With Debian, tests can be conducted under different Python environments. (It's also possible to use virtual environments, but it seems that this wasn't done in the build.yml).

  2. Personally, I think that most people are using the Debian system as a server system, so maybe it's necessary to conduct tests.

lovelxc avatar Dec 20 '24 14:12 lovelxc