qiling icon indicating copy to clipboard operation
qiling copied to clipboard

Published 20 hours ago • verified publisher icon qilingframework

Fix use pread/pwrite when unavailable

Open tututu-patch opened this issue 3 years ago • 6 comments

Checklist

Which kind of PR do you create?

  • [√ ] This PR only contains minor fixes.
  • [ ] This PR contains major feature update.
  • [ ] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [ ] The new code conforms to Qiling Framework naming convention.
  • [ ] The imports are arranged properly.
  • [ ] Essential comments are added.
  • [ ] The reference of the new code is pointed out.

Extra tests?

  • [ ] No extra tests are needed for this PR.
  • [ ] I have added enough tests for this PR.
  • [ ] Tests will be added after some discussion and review.

Changelog?

  • [ ] This PR doesn't need to update Changelog.
  • [ ] Changelog will be updated after some proper review.
  • [ ] Changelog has been updated in my PR.

Target branch?

  • [ ] The target branch is dev branch.
  • [√ ] master branch

One last thing

tututu-patch avatar Dec 12 '21 04:12 tututu-patch

Hi, why do you need this patch?

wtdcode avatar Dec 12 '21 10:12 wtdcode

Some Python OS modules do not have the pread attribute. Then he will report an error.

tututu-patch avatar Dec 13 '21 16:12 tututu-patch

Some Python OS modules do not have the pread attribute. Then he will report an error.

Could you provide a sample source or test binary? btw, you are failing CI.

wtdcode avatar Dec 13 '21 17:12 wtdcode

My English is not good. Can I add your wechat?

tututu-patch avatar Dec 14 '21 12:12 tututu-patch

My English is not good. Can I add your wechat?

the CI test failed :)

xwings avatar Dec 28 '21 04:12 xwings

Yes, I have communicated with @wtdCode that other systems will fail if I change them this way.

tututu-patch avatar Dec 28 '21 04:12 tututu-patch

Close for now

xwings avatar Oct 06 '22 03:10 xwings