quaff icon indicating copy to clipboard operation
quaff copied to clipboard

Updated to Elixir 1.0.5, removed rebar stuff

Open thecodeboss opened this issue 10 years ago • 3 comments

I also included various style changes to reflect some Elixir standards. Newlines added to a few files.

Lastly, I changed the Travis script to simplify it slightly.

Feel free to suggest stuff, and let me know if my changes are a bit too drastic.

thecodeboss avatar Aug 14 '15 19:08 thecodeboss

I've merged the older PR 4 (I've been a bit negligent here, sorry :-) ) This disables compiling via rebar in travis, but I don't want to remove the rebar tooling. You'll need to rebase to resolve the conflicts.

Also, your single commit is a bit large; could you split up into a couple of commits -- one with the change to 1.0.5 and whatever code changes are needed for that, and another with the style changes?

qhool avatar Sep 10 '15 03:09 qhool

@qhool With the exception of including .ez files in the .gitignore, this PR seems very reasonable; This project no longer compiles under Elixir > 1.0.

scohen avatar Dec 08 '15 19:12 scohen

In terms of splitting this into multiple commits, I think it would be a lot of work to separate the 1.0.5 vs. style changes. A lot of code was auto-generated too.

I can look into redoing the rebar stuff when I've got time, but I'm not familiar with rebar, and don't currently have access to an Elixir environment (or even the original code I put up here, though it's easy enough to clone again).

thecodeboss avatar Dec 08 '15 19:12 thecodeboss