data-curator icon indicating copy to clipboard operation
data-curator copied to clipboard

Support missing values at field level

Open Stephen-Gates opened this issue 7 years ago • 9 comments
trafficstars

Desired Behaviour

Support missingValues at field level - possible changes in specification. See https://github.com/frictionlessdata/specs/issues/551

  • Add property to column
  • Use property in validation

Stephen-Gates avatar Jan 10 '18 02:01 Stephen-Gates

Note this PR https://github.com/frictionlessdata/specs/pull/588 for "no missing values".

Need to think about the UI for this

  • table vs column level
  • explaining the difference between the required constraint and no missingValues

Stephen-Gates avatar Feb 03 '18 10:02 Stephen-Gates

/remind me on april 24 to write the acceptance test for:

Stephen-Gates avatar Mar 28 '18 12:03 Stephen-Gates

@Stephen-Gates set a reminder for Apr 24th 2018

reminders[bot] avatar Mar 28 '18 12:03 reminders[bot]

User interface thoughts:

Use missing values ui from Table Properties on Column Properties

screenshot 2018-04-01 11 16 05

Update tooltips to reflect if values apply to Table or Column. Explain the Column missing values inherit from the Table values Explain that missing value characters will be interpreted as null

Stephen-Gates avatar Apr 01 '18 01:04 Stephen-Gates

Validate different missing values by column acceptance test done

https://app.cucumber.pro/projects/data-curator/documents/branch/develop/test/features/tools/validate-table.feature#scenario-set-different-missing-values-across-columns

Stephen-Gates avatar Apr 06 '18 03:04 Stephen-Gates

@mattRedBox just realised that this isn't part of the spec yet or even a pattern. I can submit a PR for a pattern. I think you said tableschema.js already supports this - correct?

Proposal https://discuss.okfn.org/t/missing-values-per-field-pattern/6571

PR https://github.com/frictionlessdata/specs/pull/608

Stephen-Gates avatar Apr 07 '18 02:04 Stephen-Gates

Hi @Stephen-Gates They have the variable in place. At the moment, each field/column has a reference to the table level missingValues. We don't copy through this reference yet, but I guess once frictionless head in that direction, it will make it simpler for frictionless to refactor so that the missingValue is specific to each field. We will then need to update what we do.

ghost avatar Apr 09 '18 23:04 ghost

Hi @Stephen-Gates So reading https://discuss.okfn.org/t/missing-values-per-field-pattern/6571, it reads correctly to me.

Open Knowledge Forums
Following on from Issues #551 in the specs, I’ve decided to propose a new pattern to add to the Frictionless Data Patterns. Looking forward to your feedback 😄 Missing values per field Overview Characters representing missing values in a table can be defined for all fields in a Tabular Data Resource using the missingValues property in a Table Schema. Values that match the missingValues are treated as null. The Missing values per field pattern allows different missing values to be specifie...

ghost avatar Apr 09 '18 23:04 ghost

:wave: @Stephen-Gates, on to write the acceptance test for:

reminders[bot] avatar Apr 24 '18 09:04 reminders[bot]