qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

WebUI: restore arrow keys table navigation

Open HanabishiRecca opened this issue 1 year ago • 5 comments

Fixup for #21007 and #21147. Table navigation with arrows (#15186) has been broken by that changes. See https://github.com/qbittorrent/qBittorrent/pull/21007#discussion_r1807326166 and https://github.com/qbittorrent/qBittorrent/pull/21147#discussion_r1807361385 for details. This PR restores the functionaly.

HanabishiRecca avatar Oct 19 '24 14:10 HanabishiRecca

I have a local branch where I'm doing same major table architecture work and thought I had broken keyboard navigation 😄 . Would you mind also fixing the left/right navigation in this same file?

Piccirello avatar Oct 19 '24 20:10 Piccirello

Would you mind also fixing the left/right navigation in this same file?

Hmm, I did not even know it was a thing. Sure.

HanabishiRecca avatar Oct 19 '24 21:10 HanabishiRecca

Hmm, I did not even know it was a thing. Sure.

It only is on the content table(s) that display a tree structure.

Piccirello avatar Oct 19 '24 21:10 Piccirello

Yeah, I found it.

Btw, rows inside BulkRenameTorrentFilesTable seem not to be selectable at all, so I'm not sure how navigation is supposed to work there.

HanabishiRecca avatar Oct 19 '24 21:10 HanabishiRecca

Btw, rows inside BulkRenameTorrentFilesTable seem not to be selectable at all, so I'm not sure how navigation is supposed to work there.

BulkRenameTorrentFilesTable is an abomination of copy/paste. It should have extended TorrentFilesTable from the start, and I may make that change. But yeah I'm not sure BulkRenameTorrentFilesTable even has that functionality, it just has the code for it.

Piccirello avatar Oct 19 '24 21:10 Piccirello

@HanabishiRecca Thank you!

Chocobo1 avatar Oct 25 '24 19:10 Chocobo1