WebUI: append port to session cookie name

[dyseg]

Prevents overwriting the shared cookie between qBt sessions on the same host. Separated from #21618. Original topic: https://github.com/qbittorrent/qBittorrent/issues/20873#issuecomment-2408992631

[glassez]

The issue of multiple qBittorrent instances under the same host was already fixed by implementing suggestion of allowing you to set custom cookie name. Original Issue is #18329. Fixed by #18384.

[dyseg]

In this case from my side this PR can be closed.

[Piccirello]

It would be really nice to fix the multi-instance scenario for users without requiring them to manually configure a custom cookie name. I suspect most users are not aware of this footgun, and so having a comprehensive fix will also prevent these users from opening GitHub issues unnecessarily.

[glassez]

It would be really nice to fix the multi-instance scenario for users without requiring them to manually configure a custom cookie name. I suspect most users are not aware of this footgun, and so having a comprehensive fix will also prevent these users from opening GitHub issues unnecessarily.

It's reasonable. But shouldn't it then completely replace the current solution with a manually set name? It hardly makes much sense to have both of them at the same time.

[Piccirello]

It's reasonable. But shouldn't it then completely replace the current solution with a manually set name? It hardly makes much sense to have both of them at the same time.

Yes, I think having this would eliminate the need for setting a custom cookie name.

[Chocobo1]

the WebUI session cookie named SID is shared between the two instances, and gets constantly overwritten.

@dyseg ~~Are you able to reproduce it with latest git master? I tested it but cannot reproduce. Browser is firefox developer edition 132 I remember I reproduced it in the past but the problem seems to have gone away now.~~

EDIT: Was a slight problem on my side, I can reproduce it now.

[dyseg]

Btw, chances are high, that other web applications name their session cookie also as SID. One example: https://github.com/gerbera/gerbera/issues/2058#issuecomment-950362846 And I'm sure that a quick github search would reveal more. Even if the dynamic cookie name is not introduced, the default name could be changed to something which is unlikely to conflict with other webapps on the same host, path.

[Piccirello]

Btw, chances are high, that other web applications name their session cookie also as SID. One example: gerbera/gerbera#2058 (comment) And I'm sure that a quick github search would reveal more. Even if the dynamic cookie name is not introduced, the default name could be changed to something which is unlikely to conflict with other webapps on the same host, path.

This is a good point. This PR switches the static portion of the name to QBT_SID, which should handle that.

[github-actions[bot]]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

[github-actions[bot]]

This PR was closed because it has been stalled for some time with no activity.