Backport changes to v5.0.x branch

[glassez]

trafficstars

• #21220
• #21295
• #21480
• #21481
• #21488
• #21528
• #21553
• #21596
• #21628

[xavier2k6]

#21064

[jibwf]

Is it possible to backport this small feature customizing the save statistics time interval #21291 into v5.0.x?

[Chocobo1]

@glassez I would suggest not backport #21064 and instead investigate the issue thoroughly. Backport should be the last resort.

[glassez]

I would suggest not backport #21064 and instead investigate the issue thoroughly. Backport should be the last resort.

No problems. I will remove it from here as soon as another solution is provided.

@Chocobo1 BTW, another quick solution that can come to my mind is to simply roll back all the basic scripts (nova2, helpers etc.) to the state of the 4.6.x branch.The situation is not so clear about the plugins themselves. It turns out that we need to keep them compatible with the release branch (aka v.5.0.x currently), and not just with the master.

[Chocobo1]

BTW, another quick solution that can come to my mind is to simply roll back all the basic scripts (nova2, helpers etc.) to the state of the 4.6.x branch.The situation is not so clear about the plugins themselves. It turns out that we need to keep them compatible with the release branch (aka v.5.0.x currently), and not just with the master.

It is already targeted to release branch (v.5.0.x) correctly. The plugins repo still run CI with older python versions.

No problems. I will remove it from here as soon as another solution is provided.

It is unclear what is the actual issue as I couldn't find a proper issue report about it and I couldn't reproduce either. I suspect it doesn't affect the masses but only a few (which is the usual with a new release). I mean, until the symptom is identified it is unlikely to have a 'fix'.

[glassez]

It is unclear what is the actual issue as I couldn't find a proper issue report about it and I couldn't reproduce either. I suspect it doesn't affect the masses but only a few (which is the usual with a new release). I mean, until the symptom is identified it is unlikely to have a 'fix'.

It sounds strange... This is one of the top issues since the v5.0 release. Just try to setup environment with clean qBittorrent v4.6.7 + Pyton v3.8.x (e.g. v3.8.10) and download official plugins (make sure that they are listed in qBittorrent plugins dialog). Then update it to v5.0. https://github.com/qbittorrent/qBittorrent/issues/21445#issuecomment-2395115393 https://github.com/qbittorrent/qBittorrent/issues/21445#issuecomment-2395118111

[xavier2k6]

@Chocobo1 It's not an upgrade issue anyway from 4.6.x -> 5.0.0, it can be re-produced with fresh profile/portable mode & python 3.8.10

1. Download/extract qBittorrent 5.0.0
2. Create profile folder
3. Ensure python 3.8.10 is installed & only version installed!
4. Run qBittorrent
5. View->Search
6. Select "Search plugins..."
7. Check for updates
8. Met with Couldn't install "xxxxxx" search engine plugin. Plugin is not supported.
9. It simply will not install the 8x official plugins.
10. Installing Python 3.9.0 by itself or selecting it from advanced options....resolves the issue.

[Chocobo1]

@Chocobo1 It's not an upgrade issue anyway from 4.6.x -> 5.0.0, it can be re-produced with fresh profile/portable mode & python 3.8.10

Thanks, I think I found the root cause. I'll submit a fix when ready.

https://github.com/qbittorrent/qBittorrent/issues/21445#issuecomment-2395115393 Therefore, https://github.com/qbittorrent/qBittorrent/pull/21064 definitely needs to be backported to v5.0.x branch.

It is not necessary. I'll fix it another way. See PR #21539.

[glassez]

Is it possible to backport this small feature customizing the save statistics time interval #21291 into v5.0.x?

By default only bugfixes are eligible for backporting into current release branch. All questions are for @Chocobo1. He is the unspoken guardian of the release policy.

[stalkerok]

Is it possible to add https://github.com/qbittorrent/qBittorrent/pull/21296 ?

[xavier2k6]

#21220? -> https://github.com/qbittorrent/qBittorrent/pull/21220#issuecomment-2345833787

[glassez]

#21220? -> #21220 (comment)

Done.

[stalkerok]

Is it possible to add #21296 ?

@Chocobo1 ?

[KyleSanderson]

https://github.com/qbittorrent/qBittorrent/pull/21300 ?

[glassez]

#21300 ?

I don't mind. The question is up to @Chocobo1. https://github.com/qbittorrent/qBittorrent/pull/21496#issuecomment-2402201337

[Chocobo1]

#21300 ?

I'm ok with it.

[stalkerok]

Is it possible to add #21296 ?

@Chocobo1 ?

What about this one?

[Chocobo1]

Is it possible to add #21296 ?

@Chocobo1 ?

What about this one?

It isn't critical, so probably not. ps. I would only reply with the OK ones.

[sledgehammer999]

I pushed #21605 to this.