qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Current iconset relies too much on Blue icons. We need more variety by using icon colors other than Blue or using 2 or more colors per icon.

Open Pentaphon opened this issue 1 year ago • 8 comments
trafficstars

We need less blue icons and more variation in icons to make them more distinct. As you can see, the current iconset relies too much on blue icons. Does the mail envelope need to be blue? Does the settings gear need to be blue? Does the torrent creator icon need to be blue? We need to use more colors and have more icons like the torrent creator icon use 2 more or more colors.

{98535517-8D96-4B73-987D-10C9E7A01AC8}

Pentaphon avatar Oct 01 '24 04:10 Pentaphon

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

glassez avatar Oct 01 '24 04:10 glassez

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

I know. The main issue we have is that nobody wants to do a total theme revamp because it is such a huge project to create from scratch. Therefore, I decided to instead create 2 issues that are more realistic to solve. This issue can realistically be pushed in time for 5.1.0. It simply involves changing as many of the blue icons we currently have to other colors.

I think this and https://github.com/qbittorrent/qBittorrent/issues/21448 are the 2 biggest issues that can be addressed without needing a total theme revamp so I made them in the event somebody sees them and does at least 1 or both of them.

Pentaphon avatar Oct 01 '24 04:10 Pentaphon

This and similar problems will not get off the ground until someone interested suggests a PR and maintain it until it is merged.

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

However, I can't make massive one PR change like last time. I

Mazino-Urek avatar Oct 01 '24 11:10 Mazino-Urek

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

It is available. You can start by using "Customize UI theme" feature even without recompiling your qBittorrent.

glassez avatar Oct 01 '24 11:10 glassez

The first step would be creating two icon folder. One for dark and the other for the light theme. As I am not a developer I can't do that. If anyone can implement that first, I can gradually change the colors of the icon.

It is available. You can start by using "Customize UI theme" feature even without recompiling your qBittorrent.

I use that option. What I am trying to say is, rather than pulling all icons from /src/icons. There will be two individual folder inside the icons folder.

Example:

/src/icons/dark and /src/icons/light

When a user selects the dark theme icon will be pulled from /src/icons/dark and in the case of light theme vice versa.

In that way, I can tune each theme icon in such a way that it is not offensive to the eyes. In my opinion, Apple has already done a great job and by using the color schemes from the color palette below can resolve the issue.

image

Mazino-Urek avatar Oct 01 '24 11:10 Mazino-Urek

What I am trying to say is, rather than pulling all icons from /src/icons. There will be two individual folder inside the icons folder.

Example:

/src/icons/dark and /src/icons/light

This is also available. The only difference is that light mode (default) icons are searched in the icons root folder (/src/icons), and dark mode icons in the dark subfolder (/src/icons/dark).

glassez avatar Oct 01 '24 14:10 glassez

This is also available. The only difference is that light mode (default) icons are searched in the icons root folder (/src/icons), and dark mode icons in the dark subfolder (/src/icons/dark).

There is no physical folder in the source code. It is probably done via code, I guess. image

Mazino-Urek avatar Oct 01 '24 17:10 Mazino-Urek

There is no physical folder in the source code. It is probably done via code, I guess.

Sure. There was no point in creating this folder, since we didn't have separate icons for the dark mode. Besides, I'm not sure if Git supports empty folders in the repository.

glassez avatar Oct 01 '24 18:10 glassez

The dark theme is terrible and it's forced if you have a dark theme on windows. It was necessary to make a separate theme switcher in the settings and not to automatically pull it up from the system!

andriybogachev avatar Oct 02 '24 03:10 andriybogachev

i currently hate the colors of all the icons and would gladly just have gray or blue icons for everything. but if possible, setting the colors of each icon would be nice.

cheater avatar Dec 14 '24 19:12 cheater

ANNOUNCEMENT!

For anybody coming across this "Feature Request" & would like/love to see a potential implementation in the future! Here are some options available to you:

  1. Please select/click the 👍 &/orreactions in the original/opening post of this ticket.

  2. Please feel free (If you have the "skillset") to create a "Pull Request" implementing what's being requested in this ticket. (new/existing contributors/developers are always welcome)


DO:

  • Provide constructive feedback.
  • Display how other projects implemented same/similar etc.

DO NOT:

  • Add a "Bump", "me too", "2nd/3rd" etc. or "criticizing" comment(s). (These will be disregarded/hidden as "spam/abuse/off-topic" etc. as they don't provide anything constructive.)

xavier2k6 avatar May 25 '25 14:05 xavier2k6